Remove redundant TODOs and unused classes

This commit is contained in:
Him188 2021-08-13 16:18:45 +08:00
parent 8a607eddaf
commit 13484c7a7a
9 changed files with 20 additions and 28 deletions

View File

@ -230,7 +230,7 @@ public class XmlMessageBuilder(
*/
public var brief: String = "",
public var flag: Int = 3,
public var url: String = "", // TODO: 2019/12/3 unknown
public var url: String = "",
public var sourceName: String = "",
public var sourceIconURL: String = ""
) {

View File

@ -91,7 +91,6 @@ OnlineFriendImage() {
} else {
"http://c2cpicdw.qpic.cn/offpic_new/0/" + delegate.resId + "/0?term=2"
}
// TODO: 2020/4/24 动态获取图片下载链接的 host
}

View File

@ -209,9 +209,9 @@ internal class OnlineMessageSourceToGroupImpl(
toUin = Mirai.calculateGroupUinByGroupCode(targetId), // group
msgType = 82, // 82?
c2cCmd = 1,
msgSeq = sequenceIds.single(), // TODO !!
msgSeq = sequenceIds.single(),
msgTime = time,
msgUid = internalIds.single().toLongUnsigned(), // TODO !!
msgUid = internalIds.single().toLongUnsigned(),
groupInfo = MsgComm.GroupInfo(groupCode = targetId),
isSrcMsg = true
),

View File

@ -19,6 +19,5 @@ internal interface ConfigPushSyncer {
internal class ConfigPushSyncerImpl : ConfigPushSyncer {
override suspend fun awaitSync() {
// TODO("Not yet implemented")
}
}

View File

@ -35,7 +35,6 @@ internal class OutgoingPacketWithRespType<R : Packet?> constructor(
delegate: ByteReadPacket
) : OutgoingPacket(name, commandName, sequenceId, delegate)
// TODO: 2021/4/12 generalize
internal open class OutgoingPacket constructor(
name: String?,
val commandName: String,

View File

@ -143,7 +143,7 @@ internal object KnownPacketFactories {
PttStore.GroupPttUp,
PttStore.GroupPttDown,
LongConn.OffPicUp,
LongConn.OffPicDown,
// LongConn.OffPicDown,
TroopManagement.EditSpecialTitle,
TroopManagement.Mute,
TroopManagement.GroupOperation,

View File

@ -14,7 +14,6 @@ import net.mamoe.mirai.internal.QQAndroidBot
import net.mamoe.mirai.internal.network.Packet
import net.mamoe.mirai.internal.network.QQAndroidClient
import net.mamoe.mirai.internal.network.protocol.data.proto.Cmd0x352
import net.mamoe.mirai.internal.network.protocol.data.proto.GetImgUrlReq
import net.mamoe.mirai.internal.network.protocol.packet.OutgoingPacket
import net.mamoe.mirai.internal.network.protocol.packet.OutgoingPacketFactory
import net.mamoe.mirai.internal.network.protocol.packet.buildOutgoingUniPacket
@ -78,20 +77,18 @@ internal class LongConn {
}
object OffPicDown : OutgoingPacketFactory<OffPicDown.ImageDownPacketResponse>("LongConn.OffPicDown") {
operator fun invoke(client: QQAndroidClient, @Suppress("UNUSED_PARAMETER") req: GetImgUrlReq): OutgoingPacket {
return buildOutgoingUniPacket(client) {
TODO()
}
}
override suspend fun ByteReadPacket.decode(bot: QQAndroidBot): ImageDownPacketResponse {
TODO("not implemented") //To change body of created functions use File | Settings | File Templates.
}
sealed class ImageDownPacketResponse : Packet {
object Success : ImageDownPacketResponse()
}
}
// object OffPicDown : OutgoingPacketFactory<OffPicDown.ImageDownPacketResponse>("LongConn.OffPicDown") {
// operator fun invoke(client: QQAndroidClient, @Suppress("UNUSED_PARAMETER") req: GetImgUrlReq): OutgoingPacket {
// return buildOutgoingUniPacket(client) {
// }
// }
//
// override suspend fun ByteReadPacket.decode(bot: QQAndroidBot): ImageDownPacketResponse {
// }
//
//
// sealed class ImageDownPacketResponse : Packet {
// object Success : ImageDownPacketResponse()
// }
// }
}

View File

@ -50,7 +50,7 @@ internal class WtLogin {
) {
writeOicqRequestPacket(client, commandId = 0x0810) {
writeShort(8) // subCommand
writeShort(6) // count of TLVs, probably ignored by server?TODO
writeShort(6) // count of TLVs, probably ignored by server?
t8(2052)
t104(client.t104)
t116(client.miscBitMap, client.subSigMap)
@ -349,7 +349,7 @@ internal class WtLogin {
}
// TODO sigMap??? =0x21410e0 // from qq
// sigMap??? =0x21410e0 // from qq
val creationTime = currentTimeSeconds()
val expireTime = creationTime + 21600

View File

@ -31,8 +31,6 @@ internal class DecryptionFailedException : Exception {
* **注意**: 此为 Mirai 内部 API. 它可能会在任何时刻被改变.
*/
internal object TEA {
// TODO: 2020/2/28 使用 stream 式输入以避免缓存
/**
* [ByteArrayPool] 缓存 [this], 然后使用 [key] 加密.
*