github-repos/make
1
0
Fork 0
mirror of https://github.com/mirror/make.git synced 2025-02-25 19:30:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

* read.c (eval): [SV 41677] Correct test for TAB vs. 8 spaces.

Browse Source
This commit is contained in:
Paul Smith 2014-07-07 03:43:57 -04:00
parent 8d577c2ff4
commit 55c00544cc
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
read.c
View File

@ -1123,7 +1123,7 @@ eval (struct ebuffer *ebuf, int set_default)
/* There's no need to be ivory-tower about this: check for /* There's no need to be ivory-tower about this: check for
one of the most common bugs found in makefiles... */ one of the most common bugs found in makefiles... */
if (cmd_prefix == '\t' && !strneq (line, " ", 8)) if (cmd_prefix == '\t' && strneq (line, " ", 8))
O (fatal, fstart, _("missing separator (did you mean TAB instead of 8 spaces?)")); O (fatal, fstart, _("missing separator (did you mean TAB instead of 8 spaces?)"));
else else
O (fatal, fstart, _("missing separator")); O (fatal, fstart, _("missing separator"));

24
tests/scripts/variables/special
View File

@ -114,4 +114,28 @@ reset-four \
: foo-three : foo-three
: foo-four'); : foo-four');
# Test that the "did you mean TAB" message is printed properly
run_make_test(q!
$x.
!,
'', '#MAKEFILE#:2: *** missing separator. Stop.', 512);
run_make_test(q!
foo:
bar
!,
'', '#MAKEFILE#:3: *** missing separator (did you mean TAB instead of 8 spaces?). Stop.', 512);
run_make_test(q!
.RECIPEPREFIX = :
foo:
bar
!,
'', '#MAKEFILE#:4: *** missing separator. Stop.', 512);
1; 1;
### Local Variables:
### eval: (setq whitespace-action (delq 'auto-cleanup whitespace-action))
### End: