github-repos/leveldb
1
0
Fork 0
mirror of https://github.com/google/leveldb.git synced 2025-04-25 14:00:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not crash if filesystem can't fsync

Browse Source 
This code moved, re-apply the fix elsewhere.

See
- https://github.com/bitcoin/bitcoin/pull/10000
- https://github.com/bitcoin-core/leveldb-old/pull/16

Original change by Nicolas Dorier <nicolas.dorier@gmail.com>, ported to leveldb 1.22 by Wladimir J. van der Laan.
This commit is contained in:
Lőrinc 2025-04-04 13:45:16 +02:00
parent ac691084fd
commit 93e3279233
1 changed files with 8 additions and 3 deletions

11
util/env_posix.cc
View File

@ -347,7 +347,7 @@ class PosixWritableFile final : public WritableFile {
return status;
}
return SyncFd(fd_, filename_);
return SyncFd(fd_, filename_, false);
}
private:
@ -382,7 +382,7 @@ class PosixWritableFile final : public WritableFile {
if (fd < 0) {
status = PosixError(dirname_, errno);
} else {
status = SyncFd(fd, dirname_);
status = SyncFd(fd, dirname_, true);
::close(fd);
}
return status;
@ -394,7 +394,7 @@ class PosixWritableFile final : public WritableFile {
//
// The path argument is only used to populate the description string in the
// returned Status if an error occurs.
static Status SyncFd(int fd, const std::string& fd_path) {
static Status SyncFd(int fd, const std::string& fd_path, bool syncing_dir) {
#if HAVE_FULLFSYNC
// On macOS and iOS, fsync() doesn't guarantee durability past power
// failures. fcntl(F_FULLFSYNC) is required for that purpose. Some
@ -414,6 +414,11 @@ class PosixWritableFile final : public WritableFile {
if (sync_success) {
return Status::OK();
}
// Do not crash if filesystem can't fsync directories
// (see https://github.com/bitcoin/bitcoin/pull/10000)
if (syncing_dir && errno == EINVAL) {
return Status::OK();
}
return PosixError(fd_path, errno);
}