github-repos/leveldb
1
0
Fork 0
mirror of https://github.com/google/leveldb.git synced 2025-01-27 06:30:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

CMakeLists.txt: fix googletest related options

Browse Source 
* https://cmake.org/cmake/help/book/mastering-cmake/chapter/Writing%20CMakeLists%20Files.html
  says that CMake options are case-sensitive and I don't see lower-case version in
  currently used googletest submodules and gtest is indeed installed with leveldb

* install_gmock option I don't see at all, so I've kept it as is, INSTALL_GTEST, BUILD_GMOCK
  do exist as upper-case

$ grep -Ri install_.*mock .
./CMakeLists.txt:  set(install_gmock OFF)
./third_party/googletest/googlemock/CMakeLists.txt:install_project(gmock gmock_main)
$ grep -Ri build_gmock .
./CMakeLists.txt:  set(BUILD_GMOCK ON)
./third_party/googletest/googletest/README.md:cmake .. -DBUILD_GMOCK=OFF
./third_party/googletest/CMakeLists.txt:option(BUILD_GMOCK "Builds the googlemock subproject" ON)
./third_party/googletest/CMakeLists.txt:if(BUILD_GMOCK)
$ grep -Ri install_gtest .
./CMakeLists.txt:  set(INSTALL_GTEST OFF)
./third_party/googletest/googletest/cmake/internal_utils.cmake:  if(INSTALL_GTEST)
./third_party/googletest/googletest/CMakeLists.txt:if (INSTALL_GTEST)
./third_party/googletest/CMakeLists.txt:option(INSTALL_GTEST "Enable installation of googletest. (Projects embedding googletest may want to turn this OFF.)" ON)

* also use CACHE and FORCE as sugested in:
  https://cmake.org/cmake/help/latest/command/set.html
  https://stackoverflow.com/questions/20239334/cmake-set-subdirectory-options
  for the value to correctly propagate into third_party/googletest subdirectory

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
This commit is contained in:
Martin Jansa 2023-10-20 22:57:48 +02:00
parent 068d5ee1a3
commit 77da477840
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CMakeLists.txt
View File

@ -295,9 +295,9 @@ if(LEVELDB_BUILD_TESTS)
# Prevent overriding the parent project's compiler/linker settings on Windows.
set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
set(install_gtest OFF)
set(install_gmock OFF)
set(build_gmock ON)
set(INSTALL_GTEST OFF CACHE BOOL "" FORCE)
set(install_gmock OFF CACHE BOOL "" FORCE)
set(BUILD_GMOCK ON CACHE BOOL "" FORCE)
# This project is tested using GoogleTest.
add_subdirectory("third_party/googletest")