github-repos/leveldb
1
0
Fork 0
mirror of https://github.com/google/leveldb.git synced 2025-03-28 12:10:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix undefined behavior due to reading iterator data after modification

Browse Source
This commit is contained in:
Leron Reznikov 2023-01-19 21:00:27 -08:00
parent aa5479bbf4
commit 6794944c00
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
db/builder.cc
View File

@ -30,14 +30,15 @@ Status BuildTable(const std::string& dbname, Env* env, const Options& options,
TableBuilder* builder = new TableBuilder(options, file); TableBuilder* builder = new TableBuilder(options, file);
meta->smallest.DecodeFrom(iter->key()); meta->smallest.DecodeFrom(iter->key());
Slice key;
for (; iter->Valid(); iter->Next()) { for (; iter->Valid(); iter->Next()) {
key = iter->key(); builder->Add(iter->key(), iter->value());
builder->Add(key, iter->value());
} }
if (!key.empty()) {
meta->largest.DecodeFrom(key); iter->SeekToLast();
if(iter->Valid()) {
meta->largest.DecodeFrom(iter->key());
} }
// Finish and check for builder errors // Finish and check for builder errors
s = builder->Finish(); s = builder->Finish();