github-repos/config
1
0
Fork 0
mirror of https://github.com/lightbend/config.git synced 2025-03-21 06:40:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Sort map keys when computing the hash for a SimpleConfigObject

Browse Source
This commit is contained in:
Havoc Pennington 2011-11-10 16:12:40 -05:00
parent 6923dec829
commit c677a23b3b
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/com/typesafe/config/impl/SimpleConfigObject.java
View File

@ -1,6 +1,9 @@
package com.typesafe.config.impl; package com.typesafe.config.impl;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Set; import java.util.Set;
@ -62,7 +65,12 @@ class SimpleConfigObject extends AbstractConfigObject {
} }
private static int mapHash(Map<String, AbstractConfigValue> m) { private static int mapHash(Map<String, AbstractConfigValue> m) {
Set<String> keys = m.keySet(); // the keys have to be sorted, otherwise we could be equal
// to another map but have a different hashcode.
List<String> keys = new ArrayList<String>();
keys.addAll(m.keySet());
Collections.sort(keys);
int valuesHash = 0; int valuesHash = 0;
for (String k : keys) { for (String k : keys) {
valuesHash += m.get(k).hashCode(); valuesHash += m.get(k).hashCode();