github-repos/config
1
0
Fork 0
mirror of https://github.com/lightbend/config.git synced 2025-03-26 20:10:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix for issue . Instead of ignoring fields without a proper getter/setter, avoid the NPE checking first that there's a field to work with.

Browse Source
This commit is contained in:
tzarouali 2017-02-20 21:29:54 +00:00
parent 4d98a0069e
commit 870dd28cc7
1 changed files with 2 additions and 4 deletions

6
config/src/main/java/com/typesafe/config/impl/ConfigBeanImpl.java
View File

@ -69,9 +69,7 @@ public class ConfigBeanImpl {
try {
List<PropertyDescriptor> beanProps = new ArrayList<PropertyDescriptor>();
for (PropertyDescriptor beanProp : beanInfo.getPropertyDescriptors()) {
if (beanProp.getReadMethod() == null
|| beanProp.getWriteMethod() == null
|| getField(clazz, beanProp.getName()) == null) {
if (beanProp.getReadMethod() == null || beanProp.getWriteMethod() == null) {
continue;
}
beanProps.add(beanProp);
@ -279,7 +277,7 @@ public class ConfigBeanImpl {
private static boolean isOptionalProperty(Class beanClass, PropertyDescriptor beanProp) {
Field field = getField(beanClass, beanProp.getName());
return (field.getAnnotationsByType(Optional.class).length > 0);
return field != null && (field.getAnnotationsByType(Optional.class).length > 0);
}
private static Field getField(Class beanClass, String fieldName) {