github-repos/config
1
0
Fork 0
mirror of https://github.com/lightbend/config.git synced 2025-02-05 17:10:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unmodifiable collection wrappers in ResolveContext

Browse Source 
This fixes #700 (Java is unhelpful and the Collections.unmodifiableList etc
methods don't check whether the thing is already wrapped).

These were just an assertion basically intended to find any accidental
modification of these collections, so not essential.
This commit is contained in:
Havoc Pennington 2020-07-24 11:20:07 -04:00
parent e0984d41b0
commit 4739cba0bd
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
config/src/main/java/com/typesafe/config/impl/ResolveContext.java
View File

@ -32,8 +32,12 @@ final class ResolveContext {
this.memos = memos;
this.options = options;
this.restrictToChild = restrictToChild;
this.resolveStack = Collections.unmodifiableList(resolveStack);
this.cycleMarkers = Collections.unmodifiableSet(cycleMarkers);
// we don't defensively copy/wrap these because Collections.unmodifiableList etc.
// nest infinitely in a way that causes stack overflow (they don't check to avoid
// multiple wrappers). But they should be treated as immutable because they end
// up shared between multiple ResolveContext.
this.resolveStack = resolveStack;
this.cycleMarkers = cycleMarkers;
}
private static Set<AbstractConfigValue> newCycleMarkers() {