github-repos/config
1
0
Fork 0
mirror of https://github.com/lightbend/config.git synced 2025-01-15 23:01:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

when AnySyntax finds nothing, concat all the exception messages

Browse Source 
previously we were discarding these which could be bad if one
of them was a weird IO problem of some kind.
This commit is contained in:
Havoc Pennington 2011-12-07 09:25:17 -05:00
parent c90f46cf78
commit 0582f33d94
1 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
config/src/main/java/com/typesafe/config/impl/ConfigImpl.java
View File

@ -52,6 +52,7 @@ public class ConfigImpl {
ConfigParseable propsHandle = source.nameToParseable(name
+ ".properties");
boolean gotSomething = false;
List<String> failMessages = new ArrayList<String>();
ConfigSyntax syntax = options.getSyntax();
@ -62,7 +63,7 @@ public class ConfigImpl {
.setSyntax(ConfigSyntax.CONF));
gotSomething = true;
} catch (ConfigException.IO e) {
failMessages.add(e.getMessage());
}
}
@ -73,7 +74,7 @@ public class ConfigImpl {
obj = obj.withFallback(parsed);
gotSomething = true;
} catch (ConfigException.IO e) {
failMessages.add(e.getMessage());
}
}
@ -84,13 +85,26 @@ public class ConfigImpl {
obj = obj.withFallback(parsed);
gotSomething = true;
} catch (ConfigException.IO e) {
failMessages.add(e.getMessage());
}
}
if (!options.getAllowMissing() && !gotSomething) {
throw new ConfigException.IO(SimpleConfigOrigin.newSimple(name), String.format(
"None of %s.conf, %s.json, %s.properties were found", name, name, name));
String failMessage;
if (failMessages.isEmpty()) {
// this should not happen
throw new ConfigException.BugOrBroken(
"should not be reached: nothing found but no exceptions thrown");
} else {
StringBuilder sb = new StringBuilder();
for (String msg : failMessages) {
sb.append(msg);
sb.append(", ");
}
sb.setLength(sb.length() - 2);
failMessage = sb.toString();
}
throw new ConfigException.IO(SimpleConfigOrigin.newSimple(name), failMessage);
}
}