github-repos/byte-unixbench
1
0
Fork 0
mirror of https://github.com/kdlucas/byte-unixbench.git synced 2025-01-10 23:40:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

make maxCopies unbounded for 'system' and 'misc' suites

Browse Source 
Quoting original author of this patch:

Simply un-limits the 'misc' and 'system' suites.

Half-related thoughts about testing quality:

I'm curious why there's a shell1, shell8, and shell16 set of tests. Aren't the
latter two equivalent to './Run -c 8 shell1' and './Run -c 16 shell1'? I think
shell8 and shell16 are pointless if this is the case.

At the very least, I think shell8 should be out of the default run (the $index
set), because it will essentially give a misleading number if you have more
than a single core in the system. Isn't the purpose of the serial run to
essentially measure how well the system performs on single-threaded activities?
Or perhaps to measure how well a single core performs? Having 'shell8' in the
$index set artificially inflates the score for serialized runs and artificially
damages the score during maxed-out parallelized runs. If you are actually
interested in seeing how well 'shell8' does on exactly one core, shouldn't you
do the equivalent of 'taskset 1' on it, forcing the child processes to stay on
that single core?

End of quote.

Signed-off-by: Carlos L. Torres <carlos.torres@rackspace.com>
This commit is contained in:
Steven Noonan 2015-06-06 17:40:32 -05:00 committed by Carlos L. Torres
parent c5cb9f2dd6
commit 910276909b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
UnixBench/Run
View File

@ -106,10 +106,10 @@ my $TESTDIR = getDir('UB_TESTDIR', $BASEDIR . "/testdir");
# Configure the categories to which tests can belong. # Configure the categories to which tests can belong.
my $testCats = { my $testCats = {
'system' => { 'name' => "System Benchmarks", 'maxCopies' => 16 }, 'system' => { 'name' => "System Benchmarks", 'maxCopies' => 0 },
'2d' => { 'name' => "2D Graphics Benchmarks", 'maxCopies' => 1 }, '2d' => { 'name' => "2D Graphics Benchmarks", 'maxCopies' => 1 },
'3d' => { 'name' => "3D Graphics Benchmarks", 'maxCopies' => 1 }, '3d' => { 'name' => "3D Graphics Benchmarks", 'maxCopies' => 1 },
'misc' => { 'name' => "Non-Index Benchmarks", 'maxCopies' => 16 }, 'misc' => { 'name' => "Non-Index Benchmarks", 'maxCopies' => 0 },
}; };
@ -1329,7 +1329,7 @@ sub runTests {
# If the benchmark doesn't want to run with this many copies, skip it. # If the benchmark doesn't want to run with this many copies, skip it.
my $cat = $params->{'cat'}; my $cat = $params->{'cat'};
my $maxCopies = $testCats->{$cat}{'maxCopies'}; my $maxCopies = $testCats->{$cat}{'maxCopies'};
next if ($copies > $maxCopies); next if ($maxCopies > 0 && $copies > $maxCopies);
# Run the benchmark. # Run the benchmark.
my $bresult = runBenchmark($bench, $params, $verbose, $logFile, $copies); my $bresult = runBenchmark($bench, $params, $verbose, $logFile, $copies);