github-repos/benchmark
1
0
Fork 0
mirror of https://github.com/google/benchmark.git synced 2024-12-26 20:40:21 +08:00
Code Issues Packages Projects Releases Wiki Activity
07996a8adc
benchmark/src
History
Jonathon Reinhart 07996a8adc
Add missing parentheses in ParseBenchMinTime() (#1545) 
The previous code was triggering a warning in Debug builds where NDEBUG
is not defined and BM_CHECK() is included:

  benchmark/src/benchmark_runner.cc: In function ‘benchmark::internal::BenchTimeType benchmark::internal::ParseBenchMinTime(const std::string&)’:
  benchmark/src/benchmark_runner.cc:212:24: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses]
    212 |            (has_suffix && *p_end == 's' || *p_end == '\0'))
        |             ~~~~~~~~~~~^~~~~~~~~~~~~~~~
  benchmark/src/check.h:82:4: note: in definition of macro ‘BM_CHECK’
     82 |   (b ? ::benchmark::internal::GetNullLogInstance()                           \
        |    ^

Add parenthesis around the && expression.

Also fix a spelling error and move the comma in the preceding comment to
improve clarity.

Tested:
- cmake -E make_directory build
- cmake -E chdir "build" cmake -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on -DCMAKE_BUILD_TYPE=Debug ../
- cmake --build "build" --config Debug
- cmake -E chdir "build" ctest --build-config Debug
2023-02-16 18:35:21 +00:00
..
arraysize.h Apply clang-format to all headers and source (#303) 2016-10-07 11:35:03 -07:00
benchmark_api_internal.cc Include the benchmark's family-name in State (#1511) 2023-01-10 16:48:17 +00:00
benchmark_api_internal.h Introduce warmup phase to BenchmarkRunner (#1130) (#1399) 2022-05-23 13:50:17 +01:00
benchmark_main.cc restore BENCHMARK_MAIN() (#1357) 2022-02-26 10:17:13 +00:00
benchmark_name.cc Fixed build issues on window (#1449) 2022-08-03 09:44:35 +01:00
benchmark_register.cc Support for QuRT OS (Hexagon RTOS) (#1497) 2022-10-04 20:43:27 +01:00
benchmark_register.h Ensure we don't need benchmark installed to pass c++ feature checks (#1456) 2022-08-04 15:33:35 +01:00
benchmark_runner.cc Add missing parentheses in ParseBenchMinTime() (#1545) 2023-02-16 18:35:21 +00:00
benchmark_runner.h Allow specifying number of iterations via --benchmark_min_time. (#1525) 2023-02-07 11:45:18 +00:00
benchmark.cc Allow specifying number of iterations via --benchmark_min_time. (#1525) 2023-02-07 11:45:18 +00:00
check.cc Fixed build issues on window (#1449) 2022-08-03 09:44:35 +01:00
check.h Ensure we don't need benchmark installed to pass c++ feature checks (#1456) 2022-08-04 15:33:35 +01:00
CMakeLists.txt bump cmake dep and docs (#1468) 2022-09-14 15:11:37 +01:00
colorprint.cc Refactor links which include "master" and change it to "main" (#1540) 2023-02-07 15:10:30 +00:00
colorprint.h Apply clang-format to all headers and source (#303) 2016-10-07 11:35:03 -07:00
commandlineflags.cc Fix Clang-Tidy warnings readability-else-after-return (#1528) 2023-01-16 12:28:48 +00:00
commandlineflags.h annotate and export public symbols (#1321) 2022-02-14 10:48:53 +00:00
complexity.cc clang-format Google on {src/,include/} (#1280) 2021-11-10 16:04:32 +00:00
complexity.h Fix typos found by codespell (#1519) 2023-01-10 12:25:32 +00:00
console_reporter.cc Fix typos found by codespell (#1519) 2023-01-10 12:25:32 +00:00
counter.cc Custom user counters: add invert modifier. (#850) 2019-08-12 17:47:46 +03:00
counter.h update header guard to match style 2019-11-25 13:05:13 +00:00
csv_reporter.cc Fixed build issues on window (#1449) 2022-08-03 09:44:35 +01:00
cycleclock.h Fixing issue with ARM64EC and MSVC (#1514) 2023-02-06 15:58:14 +00:00
internal_macros.h Support for QuRT OS (Hexagon RTOS) (#1497) 2022-10-04 20:43:27 +01:00
json_reporter.cc Fixed build issues on window (#1449) 2022-08-03 09:44:35 +01:00
log.h Ensure we don't need benchmark installed to pass c++ feature checks (#1456) 2022-08-04 15:33:35 +01:00
mutex.h prefix macros to avoid clashes (#1186) 2021-06-24 18:21:59 +01:00
perf_counters.cc Fix typos found by codespell (#1519) 2023-01-10 12:25:32 +00:00
perf_counters.h annotate and export public symbols (#1321) 2022-02-14 10:48:53 +00:00
re.h prefix macros to avoid clashes (#1186) 2021-06-24 18:21:59 +01:00
reporter.cc Support for QuRT OS (Hexagon RTOS) (#1497) 2022-10-04 20:43:27 +01:00
sleep.cc clang-format Google on {src/,include/} (#1280) 2021-11-10 16:04:32 +00:00
sleep.h Replace int64_t usages with 'int' instead. (#359) 2017-03-27 18:32:12 -06:00
statistics.cc Small optimization to counter map management (#1382) 2022-04-07 14:37:22 +01:00
statistics.h Fix typos found by codespell (#1519) 2023-01-10 12:25:32 +00:00
string_util.cc Fix Clang-Tidy warnings readability-else-after-return (#1528) 2023-01-16 12:28:48 +00:00
string_util.h Ensure we don't need benchmark installed to pass c++ feature checks (#1456) 2022-08-04 15:33:35 +01:00
sysinfo.cc Fix typos found by codespell (#1519) 2023-01-10 12:25:32 +00:00
thread_manager.h clang-tidy: readability-redundant and performance (#1298) 2021-12-06 11:18:04 +00:00
thread_timer.h prefix macros to avoid clashes (#1186) 2021-06-24 18:21:59 +01:00
timers.cc Support for QuRT OS (Hexagon RTOS) (#1497) 2022-10-04 20:43:27 +01:00
timers.h Make PauseTiming() and ResumeTiming() per thread. (#286) 2016-09-02 21:34:34 -06:00