Commit Graph

488 Commits

Author SHA1 Message Date
Chris Kennelly
54e18b8992 Resolve benchmark cleanup race condition in issue #20.
The multithreaded API for benchmarks provides that teardown can happen in
thread 0.  For this to be safe, all other threads executing the benchmark
function need to have exited.  Otherwise, thread 0 may begin to teardown shared
resources before the other threads have stopped using these resources as they
are in their last loop of while (KeepRunning()) { ... }.

This change creates a single exit point for KeepRunning() to return false.
When running a multithreaded benchmark, thread 0 blocks on KeepRunning() until
all other threads have exited.  This approach allows for there to be no change
to the user-facing API exemplified in the BM_MultiThreaded example.
2014-05-05 09:38:08 -07:00
Chris Kennelly
9f27edbb16 Resolve memory leak from benchmark instances in google/benchmark#17.
This shifts registration from a global vector to a singleton that manages
benchmark destruction during shutdown.
2014-04-23 01:17:47 -07:00
Chris Kennelly
fa908926c7 Partially resolve google/benchmark#17 by fixing regular expression leak.
This adds a unit test to validate the wrapper without running the entirety of
benchmark_test.
2014-04-23 00:56:17 -07:00
Chris Kennelly
e38fde6450 Setup targets from each directory, rather than the top-level. 2014-04-23 00:47:07 -07:00
Arne Beer
feea2f022f Compile warning removed, adding myself to contributors 2014-04-06 22:03:51 +02:00
Arne Beer
50f459d2c0 Unable to compile because of unused parameter
There is a unused parameter at benchmark:866 Benchmark::MeasurePeakHeapMemory .
The function is marked as TODO and the code that uses the parameter is commented out.
I just removed the parameter so it can compile again without editing the CMake compile flags.
2014-04-06 16:42:24 +02:00
Felix Homann
a7c57939c8 Fix cycleclock.h for gcc/ARM.
Currently there are tests for ARMV3 and ARMV6 in cycleclock.h which are not
defined using gcc on ARM. Since there is also a cast to the unknown type
int64 I assume that the ARM code has not been tested. Therefore this patch
replaces the checks for ARMV3 and ARMV6 by checks for __ARM_ARCH. Also, the
cast to int64 is fixed by casting to int64_t.
2014-03-18 17:04:40 +01:00
Yusuke Suzuki
45b79c3e01 Check families is not nullptr before using it
When there's no benchmarks, families becomes nullptr. So before touching
it, we need to ensure families is not nullptr.
2014-02-23 20:19:07 +09:00
Dominic Hamon
be84ed0373 Remove old NOTEs 2014-01-21 19:27:04 -08:00
Eugene Zhuk
772ff6f1f1 [#4] Cleaned up FastClock background thread. 2014-01-20 23:18:25 -08:00
Eugene Zhuk
ceea4cb380 [#4] A few minor changes. 2014-01-20 22:32:16 -08:00
Eugene Zhuk
4ed4ff9574 Fix shutting down FastClock's thread on OSX. 2014-01-18 00:50:45 -08:00
Dominic Hamon
d184b2be2b Move linux-only variable into linux/cygwin block 2014-01-16 13:20:59 -08:00
Dominic Hamon
e2633b9bd7 sysinfo conditional compilation fixes for OSX 2014-01-16 09:13:18 -08:00
Dominic Hamon
c44662e7e9 Missing headers for sysctl stuff on OSX 2014-01-15 16:09:18 -08:00
Dominic Hamon
77cd9803ce add pedantic errors and fix them 2014-01-10 15:07:04 -08:00
Dominic Hamon
5a71bd6e66 More formatting tweaks 2014-01-09 12:19:02 -08:00
Dominic Hamon
78fa0b93ab Merged with upstream 2014-01-09 12:16:51 -08:00
Dominic Hamon
4ce184d86d Code reformat 2014-01-09 12:12:11 -08:00
Dominic Hamon
8009351938 Minimum iteration and overhead support.
Ensure we run at least 1 iteration.
Take into account overhead of an empty benchmark.
Minor cleanup of code.
2014-01-09 11:53:14 -08:00
Dominic Hamon
3fb8268eab Add LICENSE and copyright headers 2014-01-09 08:01:34 -08:00
Dominic Hamon
577f7410d1 Explicitly remove unsupported memory usage support 2014-01-08 09:11:50 -08:00
Dominic Hamon
dc5b533adb Remove tunable estimate for cycles per second 2014-01-08 09:11:07 -08:00
Dominic Hamon
acc65f48d3 Allow custom reporters 2014-01-07 16:33:40 -08:00
Dominic Hamon
2ff306af30 Fix right-alignment of items/s 2014-01-07 14:33:59 -08:00
Dominic Hamon
fc52b86270 Remove dead code, tidy output 2014-01-07 13:45:50 -08:00
Dominic Hamon
e5f5a0d30e Report mean/stddev times as mean/stddev 2014-01-07 13:33:45 -08:00
Dominic Hamon
2923a481ed Multithreaded tests are reenabled 2014-01-07 13:15:26 -08:00
Dominic Hamon
15bf66750c Really drop multithreading support 2013-12-20 15:10:46 -08:00
Dominic Hamon
d44b01a9cc Merging in work from branch 2013-12-20 14:39:09 -08:00
Dominic Hamon
902fb91226 benchmark_repetitions now work 2013-12-20 14:38:15 -08:00
Dominic Hamon
3a6f24c67b benchmark_iterations works as expected 2013-12-19 17:21:34 -08:00
Dominic Hamon
b3f0d71e50 benchmark_min_time now works as expected 2013-12-19 17:16:40 -08:00
Dominic Hamon
d4ed240426 Added some missing atomics in FastClock 2013-12-19 17:04:54 -08:00
Dominic Hamon
a94b0a6741 Remove duplicated macros header 2013-12-19 16:45:53 -08:00
Dominic Hamon
9a25f47250 Fix printing of time 2013-12-19 16:23:25 -08:00
Dominic Hamon
e390e4ebc3 Adding benchmark namespace and removing broken flags 2013-12-19 16:18:09 -08:00
Dominic Hamon
403f354423 Initial commit
Benchmark library builds and runs but only single-threaded. Multithreaded
support needs a bit more love.

Currently requires some C++11 support (g++ 4.6.3 seems to work).
2013-12-18 16:58:23 -08:00