1582 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dominic Hamon	b32ae9c9af	remove noenable_bzlmod as workspace support is going away	2024-12-10 12:04:53 +00:00
Nicholas Junge	b2b0aab464	Fix malformed clang invocation in build_ext.run (#1884) ... The fix is, unsurprisingly, to not invoke clang at all, because we use Bazel to build everything anyway. This also means that we can drop the setuptools pin.	2024-12-03 17:42:57 +00:00
Nicholas Junge	3d88affa59	Remove if statement from wheel upload job (#1883) ... This to see if it works with the new artifact download config.	2024-11-29 11:55:32 +00:00
Nicholas Junge	4b0533b726	Add artifact name to download before wheel PyPI upload (#1882) ... Otherwise, the folder structure gets messed up, and twine errors out.	2024-11-29 11:06:08 +00:00
Dominic Hamon	c58e6d0710	v1.9.1 bump	2024-11-28 16:51:38 +00:00
Guo Ci	d26047a0ac	Improve examples on ComputeStatistics (#1881)	2024-11-27 09:41:06 +00:00
dominic	62a321d6dc	update standard to C++17 per C++ build support (#1875) ... * update standard to C++17 per C++ build support * disable deadcode checks from clang-tidy * fix redundant definition of constexpr	2024-11-13 13:06:48 +00:00
Nicholas Junge	50ffd3e546	Declare a Python 3.13 toolchain, revert setup.py toolchain arget selection (#1876) ... The new solution was too smart (read: dense), because it did not account for the fact that we look for the Windows libs of the interpreter building the wheel, not the hermetic one supplying the header files. The fix is to just align the versions again, so that the libs and headers come from the same minor version.	2024-11-07 15:04:51 +00:00
Nicholas Junge	a6af6eeb6a	Add a Python matrix to ensure the bindings build on all supported versions (#1871) ... Also contains a run of `pre-commit autoupdate`, and a bump of cibuildwheel to its latest tag for CPython 3.13 support. But, since we build for 3.10+ with SABI from 3.12 onwards, we don't even need a dedicated Python 3.13 build job or toolchain - the wheels from 3.12 can be reused. Simplifies some version-dependent logic around assembling the bazel build command in setup.py, and fixes a possible unbound local error in the toolchain patch context manager.	2024-11-06 13:15:22 +00:00
Nicholas Junge	d99cdd7356	Add nb::is_flag() annotation to Counter::Flags (#1870) ... This saves us the definition of `__or__`, because we can just use the one from `enum.IntFlag`.	2024-10-28 18:18:40 +00:00
Richard Cole	4e3f2d8b67	[#1487] ensure that when printing color text the background color of the terminal on windows is preserved (#1865) ... Co-authored-by: dominic <510002+dmah42@users.noreply.github.com>	2024-10-24 12:31:06 +01:00
xdje42	ffc727a859	Verify RegisterProfilerManager doesn't overwrite an existing registration (#1837) ... * Verify RegisterProfilerManager doesn't overwrite an existing registration Tested: Add a second registration to test/profiler_manager_test.cc and verify the test crashes as expected. * Verify RegisterProfilerManager doesn't overwrite an existing registration Tested: Configure with: cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -DBENCHMARK_DOWNLOAD_DEPENDENCIES=on Then run: ctest -R profiler_manager_gtest Before change test fails (expected), after change test passes (expected) --------- Co-authored-by: dominic <510002+dmah42@users.noreply.github.com>	2024-10-24 10:22:58 +01:00
dominic	c45d9c4c2f	bump googletest version to match bazel (#1868) ... * bump googletest version to match bazel * bump minimum cmake to 3.13 per supported versions	2024-10-24 09:46:02 +01:00
Nicholas Junge	be2134584d	Update nanobind_bazel to v2.2.0 (#1866) ... Adds support for free-threaded nanobind extension builds, though we don't currently build a free-threaded wheel. Co-authored-by: dominic <510002+dmah42@users.noreply.github.com>	2024-10-23 10:38:53 +01:00
dominic	498714357f	upgrade bazel mods. requires c++14 for tests (#1867)	2024-10-23 10:27:18 +01:00
Alfredo Daniel Esponda Cervantes	761305ec3b	Update user_guide.md (#1863) ... PR for Issue #819: Fix Suffix in Console Format Table This PR fixes an issue with an incorrect suffix displayed in the console output. Fixes #819.	2024-10-12 00:16:37 +03:00
Alecto Irene Perez	0c998f7cc4	Fix spurious warning 'misc-use-anonymous-namespace' (#1860) (#1861) ... Disables 'misc-use-anonymous-namespace' for usage of the BENCHMARK macro. This warning is spurious, and the variable declared by the BENCHMARK macro can't be moved into an annonymous namespace. We don't want to disable it globally, but it can be disabled locally, for the `BENCHMARK` statement, as this warning appears downstream for users. See: https://clang.llvm.org/extra/clang-tidy/#suppressing-undesired-diagnostics	2024-10-11 01:02:36 +03:00
Devon Loehr	24e0bd827a	Add enum value from newest Windows SDK (#1859) ... * Add enum value from newest Windows SDK Windows SDK version 10.0.26100.0 adds a cache type value, `CacheUnknown`. This adds a case for that type to `sysinfo.cc`, which will otherwise complain about the switch statement being non-exhaustive when building with the new SDK. Since the value doesn't exist in prior SDK versions, we only add the case conditionally. The condition can be removed if we ever decide to bump up the required SDK version. * Fix SDK version macro Make sure the version macro we're using for the SDK is properly indicative of version 10.0.26100.0. Also fix formatting complains from the linter. * Add space to satisfy formatter Formatter insists on two space before a comment after a macro... * Change preprocessor condition Try detecting the current SDK version in a slightly different way. * Replace NTDDI_WIN11_GE with its value Undefined constants are treated as 0 by the preprocessor, which causes the check to trivially return true for previous SDK versions. Replace the constant with its value (from the newest SDK version) instead,	2024-10-02 09:40:03 +01:00
Alfredo Daniel Esponda Cervantes	23d8c1e589	Version string correction in pkg-config files (#1858) ... Co-authored-by: Alfredo Daniel Esponda Cervantes <92197886+DanEC1211@users.noreply.github.com>	2024-09-26 17:56:16 +01:00
Dominic Hamon	3fd1e6a7ae	add dry run docs	2024-09-13 10:06:24 +01:00
dominic	72ecc4ea67	Added the functionality for a dry run benchmark called through the cli argument --benchmark_dry_run. (#1851) ... * Added benchmark_dry_run boolean flag to command line options * Dry run logic to exit early and override iterations, repetitions, min time, min warmup time * Changeddry run override logic structure and added dry run to context --------- Co-authored-by: Shaan <shaanmistry03@gmail.com> Co-authored-by: Shaan Mistry <49106143+Shaan-Mistry@users.noreply.github.com>	2024-09-12 15:50:52 +01:00
Richard Cole	08fdf6eb84	enable the /MP MSVC compiler argument for parallel compilation (#1846)	2024-09-05 22:28:43 +01:00
Nicholas Junge	986423a62d	Bump oldest supported Python to 3.10, eliminate setuptools-scm (#1842) ... * Supply MacOS deployment target to delocate, use build+uv frontend This shaves off multiple minutes from the wheel builds alone. Also revert to trusted publishing for wheel uploads as it is now set up. * Bump oldest supported Python to 3.10, eliminate setuptools-scm The version is now a string again, under the same attribute as it was before. This is a pragmatic decision in order to be able to upload wheels again, possibly directly from main. We could in the future also set the Python version to a development version if we want to avoid accidental uploads of `main`. * Add a note on supported Python versions in the docs Also fixes the setuptools failure observed in the latest CI by pinning to the last version before v73 until the problem is identified and resolved.	2024-09-04 17:42:07 +01:00
Igor Zhukov	c19cfee61e	Fix C4459: Rename a function parameter profiler_manager to avoid hiding the global declaration. (#1839) ... * Fix C4459: Rename a function parameter `profiler_manager` to avoid hiding the global declaration. * Treat warnings as errors for MSVC * disable one warning for MSVC	2024-08-19 06:39:37 +03:00
Chris Kennelly	6126d2a205	Align benchmark::State to a cacheline. (#1230) ... * Align benchmark::State to a cacheline. This can avoid interference with neighboring objects and stabilize benchmark results. * separate cachline definition from alignment attribute macro Co-authored-by: Roman Lebedev <lebedev.ri@gmail.com> --------- Co-authored-by: dominic <510002+dmah42@users.noreply.github.com> Co-authored-by: Roman Lebedev <lebedev.ri@gmail.com>	2024-08-16 16:10:18 +01:00
Alex Bilger	437fea4b54	Fix Python manual timing example (#1722) ... According to the user guide, when manual timing, it is necessary to explicit it by using the `UseManualTime` function. Its equivalent in Python is use_manual_time(). This function was not called in the example. It is possible to verify that the use of this function has an impact on the measure by adding another `time.sleep(0.01)` at the end of the iteration. There is a x2 difference depending on whether `use_manual_time()` is used or not. Co-authored-by: dominic <510002+dmah42@users.noreply.github.com>	2024-08-16 15:32:48 +01:00
Dominic Hamon	ec3dc37b60	separate wheel versions in an effort to avoid timeouts	2024-08-16 11:56:56 +01:00
Dominic Hamon	12235e2465	v1.9.0	2024-08-16 11:08:15 +01:00
dominic	a008bf82f4	Ensure reported Time is walltime by removing spurious scaling by threads (#1836) ... * change the default to not scale	2024-08-13 18:12:02 +01:00
Ikko Eltociear Ashimine	b884717437	chore: update perf_counters.cc (#1831) ... peformance -> performance	2024-08-05 10:05:40 +01:00
mosfet80	ef73a30083	Update clang-format-lint-action (#1829) ... Colorize output in github action Co-authored-by: dominic <510002+dmah42@users.noreply.github.com>	2024-08-02 11:06:00 +01:00
mosfet80	7971a63070	Cache upd (#1830) ... * Update bazel.yml switch to node20 updated actions/cache to v4 * Update pre-commit.yml switch to node20 updated actions/cache to v4	2024-08-02 10:56:57 +01:00
xdje42	ebb5e3922d	Move ProfilerManager Start/Stop routines closer to actual benchmark #1807 (#1818) ... Previously, the Start/Stop routines were called before the benchmark function was called and after it returned. However, what we really want is for them to be called within the core of the benchmark: for (auto _ : state) { // This is what we want traced, not the entire BM_foo function. }	2024-08-01 08:42:41 +01:00
Nicholas Junge	25e5c52a11	Bump nanobind-bazel to v2.1.0, add stubgen target (#1824) ... Adds a stub file for the `google_benchmark._benchmark` submodule, generated with the new `nanobind_stubgen` rule released in nanobind_bazel v2.1.0. Tweaks the setup.py logic a little bit to package stub files with the rest of the build artifacts. Also explicitly adds the generated stub and marker files to the list of package data artifacts. Co-authored-by: dominic <510002+dmah42@users.noreply.github.com>	2024-07-30 15:49:33 +01:00
mosfet80	ac80572f17	Update nanobind into benchmark_deps.bzl (#1826) ... * Update nanobind into benchmark_deps.bzl * Update benchmark_deps.bzl	2024-07-30 15:05:08 +01:00
mosfet80	cfb7e0a330	Update libs into .pre-commit-config.yaml (#1825)	2024-07-30 14:09:31 +01:00
dominic	378fe693a1	Use log2 now that NDK requires at least API 21 which includes it. (#1822) ... Fixes #1820	2024-07-24 14:25:32 +01:00
Devon Loehr	fa236ed6e6	Suppress invalid-offsetof warning for clang (#1821) ... For several compilers, `benchmark.cc` suppresses a warning regarding its use of `offsetof`. This merely extends that suppression to cover clang as well.	2024-07-24 13:12:04 +01:00
Nicholas Junge	df44bf7187	Revert to token authentication for PyPI wheel uploads (#1819) ... Until the PyPI account is recovered, it should be possible to upload wheels with the GitHub secrets that were previously used. Changes the PyPI upload action sourcing to point to the v1 stable release branch, which receives rolling updates and is the canonical way of including the wheel publishing action. Uploading will probably need another release, because setuptools_scm needs to produce a clean tag that the PyPI API allows as an upload.	2024-07-23 14:49:06 +01:00
Peter Hawkins	64b5d8cd11	Update benchmark Python bindings for nanobind 2.0, and update to nanobind 2.0. (#1817) ... Incorporates the nanobind_bazel change from https://github.com/google/benchmark/pull/1795. nanobind 2.0 reworked the nanobind::enum_ class so it uses a real Python enum or intenum rather than its previous hand-rolled implementation. https://nanobind.readthedocs.io/en/latest/changelog.html#version-2-0-0-may-23-2024 As a consequence of that change, nanobind now checks when casting an integer to a enum value that the integer corresponds to a valid enum. Counter::Flags is a bitmask, and many combinations are not valid enum members. This change: a) sets nb::is_arithmetic(), which means Counter::Flags becomes an IntEnum that can be freely cast to an integer. b) defines the | operator for flags to return an integer, not an enum, avoiding the error. c) changes Counter's constructor to accept an int, not a Counter::Flags enum. Since Counter::Flags is an IntEnum now, it can be freely coerced to an int. If https://github.com/wjakob/nanobind/pull/599 is merged into nanobind, then we can perhaps use a flag enum here instead.	2024-07-18 16:54:02 +01:00
Dominic Hamon	a6ad7fbbdc	preparing for v1.8.5	2024-07-18 11:13:04 +01:00
Dominic Hamon	ad2b1c9ed1	clang format yet again	2024-07-17 16:49:12 +01:00
Dominic Hamon	4b184d47a4	update actions/checkout to v4	2024-07-17 16:47:54 +01:00
Dominic Hamon	44507bc91f	another reversal of something that breaks on wasm	2024-07-17 16:39:15 +01:00
Dominic Hamon	299a8b881d	clang format header fixes	2024-07-17 13:27:41 +01:00
Dominic Hamon	99410f400c	clang-format fixes	2024-07-17 13:25:16 +01:00
Dominic Hamon	a73c039b1d	roll back fatal error that breaks some platform (wasm) expectations	2024-07-17 13:18:38 +01:00
Dominic Hamon	65668db273	revert perf counters change until we can do the full version	2024-07-16 17:45:30 +01:00
Dominic Hamon	14ddd77a90	remove old travis config	2024-07-16 17:39:51 +01:00
xdje42	7c8ed6b082	[FR] Add API to provide custom profilers #1807 (#1809) ... This API is akin to the MemoryManager API and lets tools provide their own profiler which is wrapped in the same way MemoryManager is wrapped. Namely, the profiler provides Start/Stop methods that are called at the start/end of running the benchmark in a separate pass. Co-authored-by: dominic <510002+dmah42@users.noreply.github.com>	2024-07-16 09:56:40 +01:00