github-repos/benchmark
1
0
Fork 0
mirror of https://github.com/google/benchmark.git synced 2025-04-13 13:01:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix runtime crash when parsing /proc/cpuinfo fails

Browse Source 
The testcase fails on sparc64, because the parsing of /proc/cpuinfo
fails and thus currently returns "0" CPUs which finally leads
to division-by-zero faults in the tests.

Fix the issue by returning at least "1" CPU which allows the
tests to run. A error message will be printed in any case.

Long-term the code should be fixed to parse the cpuinfo output
on sparch which looks like this:
...
type            : sun4v
ncpus probed    : 48
ncpus active    : 48
This commit is contained in:
Helge Deller 2025-01-08 21:43:25 +01:00
parent 077db43001
commit d893156176
1 changed files with 3 additions and 1 deletions

4
src/sysinfo.cc
View File

@ -561,10 +561,12 @@ int GetNumCPUsImpl() {
}
int GetNumCPUs() {
const int num_cpus = GetNumCPUsImpl();
int num_cpus = GetNumCPUsImpl();
if (num_cpus < 1) {
std::cerr << "Unable to extract number of CPUs. If your platform uses "
"/proc/cpuinfo, custom support may need to be added.\n";
/* There is at least one CPU which we run on. */
num_cpus = 1;
}
return num_cpus;
}