github-repos/benchmark
1
0
Fork 0
mirror of https://github.com/google/benchmark.git synced 2025-02-26 11:20:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove old NOTEs

Browse Source
This commit is contained in:
Dominic Hamon 2014-01-21 19:27:04 -08:00
parent 772ff6f1f1
commit be84ed0373
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/benchmark.cc
View File

@ -467,8 +467,6 @@ class State::FastClock {
// This method is very fast. // This method is very fast.
inline bool HasReached(int64_t when_micros) { inline bool HasReached(int64_t when_micros) {
return std::atomic_load(&approx_time_) >= when_micros; return std::atomic_load(&approx_time_) >= when_micros;
// NOTE: this is the same as we're dealing with an int64_t
// return (base::subtle::NoBarrier_Load(&approx_time_) >= when_micros);
} }
// Returns the current time in microseconds past the epoch. // Returns the current time in microseconds past the epoch.
@ -490,8 +488,6 @@ class State::FastClock {
void InitType(Type type) { void InitType(Type type) {
type_ = type; type_ = type;
std::atomic_store(&approx_time_, NowMicros()); std::atomic_store(&approx_time_, NowMicros());
// NOTE: This is the same barring a memory barrier
// base::subtle::Release_Store(&approx_time_, NowMicros());
} }
private: private:
@ -524,12 +520,9 @@ class State::FastClock {
ts.tv_sec += ts.tv_nsec / kNumNanosPerSecond; ts.tv_sec += ts.tv_nsec / kNumNanosPerSecond;
ts.tv_nsec %= kNumNanosPerSecond; ts.tv_nsec %= kNumNanosPerSecond;
// NOTE: this should probably be platform specific.
pthread_cond_timedwait(&bg_cond_, &bg_mutex_, &ts); pthread_cond_timedwait(&bg_cond_, &bg_mutex_, &ts);
std::atomic_store(&approx_time_, NowMicros()); std::atomic_store(&approx_time_, NowMicros());
// NOTE: same code but no memory barrier. think on it.
// base::subtle::Release_Store(&approx_time_, NowMicros());
} }
} }