github-repos/benchmark
1
0
Fork 0
mirror of https://github.com/google/benchmark.git synced 2025-03-31 14:40:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Upgrade google/benchmark to use nanobind-bazel v2.0.0

Browse Source 
This enables binding extension builds with nanobind@v2.

Due to some backwards-incompatible changes in the treatment of enums,
`Counter::Flags` (a flag-based enum) needs to be explicitly marked as
arithmetic; setting flags is done as before with the logical "or"
operator (now bound like any other class method as `__or__()`, the
Python logical or operator slot).

The bindings changes were suggested by @hawkinsp in the corresponding
issue on the repo, see https://github.com/google/benchmark/issues/1790.
This commit is contained in:
Nicholas Junge 2024-05-29 09:21:34 +02:00
parent 7f0e99af54
commit 7eb18fabd7
2 changed files with 3 additions and 3 deletions
MODULE.bazel
bindings/python/google_benchmark
benchmark.cc

2
MODULE.bazel
View File

@ -38,4 +38,4 @@ use_repo(pip, "tools_pip_deps")
# -- bazel_dep definitions -- #
bazel_dep(name = "nanobind_bazel", version = "1.0.0", dev_dependency = True)
bazel_dep(name = "nanobind_bazel", version = "2.0.0", dev_dependency = True)

4
bindings/python/google_benchmark/benchmark.cc
View File

@ -118,7 +118,7 @@ NB_MODULE(_benchmark, m) {
using benchmark::Counter;
nb::class_<Counter> py_counter(m, "Counter");
nb::enum_<Counter::Flags>(py_counter, "Flags")
nb::enum_<Counter::Flags>(py_counter, "Flags", nb::is_arithmetic())
.value("kDefaults", Counter::Flags::kDefaults)
.value("kIsRate", Counter::Flags::kIsRate)
.value("kAvgThreads", Counter::Flags::kAvgThreads)
@ -130,7 +130,7 @@ NB_MODULE(_benchmark, m) {
.value("kAvgIterationsRate", Counter::Flags::kAvgIterationsRate)
.value("kInvert", Counter::Flags::kInvert)
.export_values()
.def(nb::self | nb::self);
.def("__or__", [](Counter::Flags a, Counter::Flags b) { return a | b; });
nb::enum_<Counter::OneK>(py_counter, "OneK")
.value("kIs1000", Counter::OneK::kIs1000)