1
0
mirror of https://github.com/google/benchmark.git synced 2025-04-01 15:11:04 +08:00

Update bazel WORKSPACE and BUILD files to work better on Windows. ()

Note, bazel only supports MSVC on Windows, and not MinGW, so
linking against shlwapi.lib only needs to follow MSVC conventions.

git_repository() did not work in local testing, so is swapped for
http_archive(). The latter is also documented as the preferred way
to depend on an external library in bazel.
This commit is contained in:
Alex Strelnikov 2018-05-02 06:23:18 -04:00 committed by Dominic Hamon
parent b678a2026d
commit 62a9d756ea
3 changed files with 7 additions and 9 deletions

View File

@ -16,7 +16,7 @@ cc_library(
]),
hdrs = ["include/benchmark/benchmark.h"],
linkopts = select({
":windows": [],
":windows": ["-DEFAULTLIB:shlwapi.lib"],
"//conditions:default": ["-pthread"],
}),
strip_include_prefix = "include",

View File

@ -73,7 +73,7 @@ We need to install the library globally now
sudo make install
```
Now you have google/benchmark installed in your machine
Now you have google/benchmark installed in your machine
Note: Don't forget to link to pthread library while building
## Stable and Experimental Library Versions
@ -933,7 +933,7 @@ sudo cpupower frequency-set --governor powersave
# Known Issues
### Windows
### Windows with CMake
* Users must manually link `shlwapi.lib`. Failure to do so may result
in unresolved symbols.

View File

@ -1,9 +1,7 @@
workspace(name = "com_github_google_benchmark")
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
git_repository(
name = "com_google_googletest",
commit = "3f0cf6b62ad1eb50d8736538363d3580dd640c3e", # HEAD
remote = "https://github.com/google/googletest",
http_archive(
name = "com_google_googletest",
urls = ["https://github.com/google/googletest/archive/3f0cf6b62ad1eb50d8736538363d3580dd640c3e.zip"],
strip_prefix = "googletest-3f0cf6b62ad1eb50d8736538363d3580dd640c3e",
)