From 56336e70f151f9eb828176e795f7c5dfe6d6bb59 Mon Sep 17 00:00:00 2001 From: Niklas Rosenstein Date: Tue, 6 Dec 2016 17:38:03 +0100 Subject: [PATCH] fix argv accessed out of bounds in ParseCommandLineFlags() (#321) --- src/benchmark.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/benchmark.cc b/src/benchmark.cc index 95f6a25b..0a5baf86 100644 --- a/src/benchmark.cc +++ b/src/benchmark.cc @@ -634,7 +634,7 @@ void ParseCommandLineFlags(int* argc, char** argv) { // TODO: Remove this. ParseStringFlag(argv[i], "color_print", &FLAGS_benchmark_color) || ParseInt32Flag(argv[i], "v", &FLAGS_v)) { - for (int j = i; j != *argc; ++j) argv[j] = argv[j + 1]; + for (int j = i; j != *argc - 1; ++j) argv[j] = argv[j + 1]; --(*argc); --i;