From 51d991f1d7e6b28b8280d44606c28e121df23db0 Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Sat, 23 Nov 2019 00:23:11 +0300 Subject: [PATCH] ParseCommandLineFlags(): do not dereference argc if it is null Higher up we dereference argc only if it is not null. But here we do no such check. --- src/benchmark.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/benchmark.cc b/src/benchmark.cc index 07942eba..b751b9c3 100644 --- a/src/benchmark.cc +++ b/src/benchmark.cc @@ -435,7 +435,7 @@ void ParseCommandLineFlags(int* argc, char** argv) { using namespace benchmark; BenchmarkReporter::Context::executable_name = (argc && *argc > 0) ? argv[0] : "unknown"; - for (int i = 1; i < *argc; ++i) { + for (int i = 1; argc && i < *argc; ++i) { if (ParseBoolFlag(argv[i], "benchmark_list_tests", &FLAGS_benchmark_list_tests) || ParseStringFlag(argv[i], "benchmark_filter", &FLAGS_benchmark_filter) ||