From fc36c301fbf92d05e30e629453a7c3282399af75 Mon Sep 17 00:00:00 2001 From: YangKeao Date: Tue, 11 Aug 2020 15:44:44 +0800 Subject: [PATCH] refine the misleading comment in test (#216) Signed-off-by: Yang Keao --- scheduler/server/schedulers/balance_test.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scheduler/server/schedulers/balance_test.go b/scheduler/server/schedulers/balance_test.go index b974a177..8ccdbdc9 100644 --- a/scheduler/server/schedulers/balance_test.go +++ b/scheduler/server/schedulers/balance_test.go @@ -15,6 +15,7 @@ package schedulers import ( "context" + "github.com/pingcap-incubator/tinykv/proto/pkg/metapb" "github.com/pingcap-incubator/tinykv/scheduler/pkg/mock/mockcluster" "github.com/pingcap-incubator/tinykv/scheduler/pkg/mock/mockoption" @@ -172,11 +173,9 @@ func (s *testBalanceRegionSchedulerSuite) TestReplacePendingRegion3C(c *C) { sb, err := schedule.CreateScheduler("balance-region", oc, core.NewStorage(kv.NewMemoryKV()), nil) c.Assert(err, IsNil) - // Store 1 has the largest region score, so the balancer try to replace peer in store 1. tc.AddRegionStore(1, 16) tc.AddRegionStore(2, 7) tc.AddRegionStore(3, 15) - // Store 4 has smaller region score than store 1 and more better place than store 2. tc.AddRegionStore(4, 10) // set pending peer @@ -187,7 +186,10 @@ func (s *testBalanceRegionSchedulerSuite) TestReplacePendingRegion3C(c *C) { region = region.Clone(core.WithPendingPeers([]*metapb.Peer{region.GetStorePeer(1)})) tc.PutRegion(region) + // region 3 has a pending peer c.Assert(sb.Schedule(tc).RegionID(), Equals, uint64(3)) + + // the peers of region 3 are in store 2, 1, and 3, so the store 4 is the only choice testutil.CheckTransferPeer(c, sb.Schedule(tc), operator.OpBalance, 1, 4) }