distributed/talent-plan-tinykv
1
0
Fork 0
mirror of https://github.com/talent-plan/tinykv.git synced 2025-01-14 06:10:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update TestProvideSnap2C in raft_test.go

Browse Source 
`handleSnapshot` only affects states in raft, not affects states in storage. More specifically, the snapshot in memory storage will be as it is after `handleSnapshot`. As a result, when leader is willing to send a snapshot to follower, it is the empty snapshot being sent. 
However, in my implementation, such a sending will be aborted since the snapshot is empty. Therefore, this test fails.
Sending an empty snapshot is definitely shall be rejected, and I update the test case to not confuse ones like me.
This commit is contained in:
niebayes 2022-09-06 10:42:57 +08:00 committed by GitHub
parent 9366a1dbe9
commit 15bec38cbb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
raft/raft_test.go
View File

@ -1055,6 +1055,8 @@ func TestProvideSnap2C(t *testing.T) {
}, },
} }
storage := NewMemoryStorage() storage := NewMemoryStorage()
// explicitly set snapshot index greater than 0, so that IsEmptySnap won't report an empty snap.
storage.snapshot.Metadata.Index = 1 // magic number.
sm := newTestRaft(1, []uint64{1}, 10, 1, storage) sm := newTestRaft(1, []uint64{1}, 10, 1, storage)
sm.handleSnapshot(pb.Message{Snapshot: &s}) sm.handleSnapshot(pb.Message{Snapshot: &s})