boost/more
1
0
Fork 0
mirror of https://github.com/boostorg/more.git synced 2025-03-23 13:10:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Expand How to write a review to include to-the-point comments made by Doug Gregor during a review.

Browse Source 
[SVN r35538]
This commit is contained in:
Beman Dawes 2006-10-10 22:09:37 +00:00
parent 1394e3c02e
commit 175a10c13a
1 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
formal_review_process.htm
View File

@ -77,6 +77,14 @@
problems along the way, please note if they are minor, serious, or
showstoppers.</p>
<p>The goal of a Boost library review is to improve the library through
constructive criticism, and at the end a decision must be made: is the
library good enough at this point to accept into Boost? If not, we hope to
have provided enough constructive criticism for it to be improved and
accepted at a later time. The Serialization library is a good example of how
constructive criticism resulted in revisions resulting in an excellent
library that was accepted in its second review.</p>
<p>Here are some questions you might want to answer in your review:</p>
<ul>
@ -113,6 +121,20 @@
comments don't obscure your overall opinion.</li>
</ul>
<p>Many reviews include questions for library authors. Authors are
interested in defending their library against your criticisms; otherwise
they would not have brought their library up for review. If you don't get a
response to your question quickly, be patient; if it takes too long or you
don't get an answer you feel is sufficient, ask again or try to rephrase the
question. Do remember that English is not the native language for many
Boosters, and that can cause misunderstandings.<br>
<br>
E-mail is a poor communication medium, and even if messages rarely get lost
in transmission, they often get drowned in the deluge of other messages.
Don't assume that an unanswered message means you're being ignored. Given
constructively, criticism will be taken better and have more positive
effects, and you'll get the answers you want.</p>
<h2><a name="Results">Results</a></h2>
<p>At the conclusion of the comment period, the Review Manager will post
@ -276,7 +298,7 @@
<hr>
<p>Revised
<!--webbot bot="Timestamp" s-type="EDITED" s-format="%d %B, %Y" startspan -->15 October, 2003<!--webbot bot="Timestamp" endspan i-checksum="38556" --></p>
<!--webbot bot="Timestamp" s-type="EDITED" s-format="%d %B, %Y" startspan -->10 October, 2006<!--webbot bot="Timestamp" endspan i-checksum="38930" --></p>
<p>© Copyright Beman Dawes 2000</p>
<p>
@ -286,4 +308,4 @@
"http://www.boost.org/LICENSE_1_0.txt">http://www.boost.org/LICENSE_1_0.txt</a>)
</p>
</body>
</html>
</html>